Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions pkg/vmcp/composer/composer.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ type WorkflowStep struct {
// ID uniquely identifies this step within the workflow.
ID string

// Type is the step type: "tool", "elicitation", "conditional"
// Type is the step type: "tool", "elicitation"
Type StepType

// Tool is the tool to call (for tool steps).
Expand Down Expand Up @@ -114,9 +114,6 @@ const (

// StepTypeElicitation requests user input via MCP elicitation protocol.
StepTypeElicitation StepType = "elicitation"

// StepTypeConditional executes based on a condition (future).
StepTypeConditional StepType = "conditional"
)

// ErrorHandler defines how to handle step failures.
Expand Down
10 changes: 0 additions & 10 deletions pkg/vmcp/composer/workflow_engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -269,11 +269,6 @@ func (e *workflowEngine) executeStep(
return e.executeToolStep(stepCtx, step, workflowCtx)
case StepTypeElicitation:
return e.executeElicitationStep(stepCtx, step, workflowCtx)
case StepTypeConditional:
// Conditional steps are not implemented in Phase 2
err := fmt.Errorf("conditional steps are not yet supported")
workflowCtx.RecordStepFailure(step.ID, err)
return err
default:
err := fmt.Errorf("unsupported step type: %s", step.Type)
workflowCtx.RecordStepFailure(step.ID, err)
Expand Down Expand Up @@ -776,11 +771,6 @@ func (*workflowEngine) validateStep(step *WorkflowStep, validStepIDs map[string]
fmt.Sprintf("elicitation message is required for step %s", step.ID),
nil)
}
case StepTypeConditional:
// Future: validate conditional step
return NewValidationError("step.type",
fmt.Sprintf("conditional steps are not yet supported (step %s)", step.ID),
nil)
default:
return NewValidationError("step.type",
fmt.Sprintf("invalid step type %q for step %s", step.Type, step.ID),
Expand Down
2 changes: 0 additions & 2 deletions pkg/vmcp/server/workflow_converter.go
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,6 @@ func parseStepType(cs *config.WorkflowStepConfig) (composer.StepType, error) {
}
case "elicitation":
stepType = composer.StepTypeElicitation
case "conditional":
stepType = composer.StepTypeConditional
default:
return "", fmt.Errorf("step %s: invalid step type %s", cs.ID, cs.Type)
}
Expand Down
Loading