moves e2e ext auth test to int test #2625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we don't need the heavy e2e tests anymore and the integration tests are a quick and fast way of asserting the correct things are being created. I've added a couple of integration tests here that test a bit more than the e2e tests (finalisers, updates etc) however during writing of the int tests it found a bug that the e2e tests let slip through. it seems that the referenced servers aren't being put into the status of the externalauth CR. I have commented this test/assertion out for now so we can use it later when we submit the fix to the controller. I will make a separate ticket for this Signed-off-by: Chris Burns <29541485+ChrisJBurns@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2625 +/- ##
==========================================
+ Coverage 55.64% 55.66% +0.02%
==========================================
Files 312 312
Lines 29885 29885
==========================================
+ Hits 16630 16636 +6
+ Misses 11811 11799 -12
- Partials 1444 1450 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Chris Burns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: Chris Burns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: Chris Burns <29541485+ChrisJBurns@users.noreply.github.com>
JAORMX
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we don't need the heavy e2e tests anymore and the integration tests are a quick and fast way of asserting the correct things are being created. I've added a couple of integration tests here that test a bit more than the e2e tests (finalizers, updates etc) however during writing of the int tests it found a bug that the e2e tests let slip through. it seems that the referenced servers aren't being put into the status of the externalauth CR. I have commented this test/assertion out for now so we can use it later when we submit the fix to the controller.
Separate ticket raised to look into status update bug #2641