Skip to content

Allow --foreground flag with --from-config #2649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2025
Merged

Allow --foreground flag with --from-config #2649

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad6c83e
Allow --foreground flag with --from-config
github-actions[bot] Nov 18, 2025
e742365
Merge branch 'main' into claude/issue-2643-20251118-2153
ChrisJBurns Nov 18, 2025
ae4ffa2
Merge branch 'main' into claude/issue-2643-20251118-2153
ChrisJBurns Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions cmd/thv/app/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,11 +485,19 @@ func validateRunFlags(cmd *cobra.Command, args []string) error {
// Validate --from-config flag usage
fromConfigFlag := cmd.Flags().Lookup("from-config")
if fromConfigFlag != nil && fromConfigFlag.Value.String() != "" {
// When --from-config is used, no other flags should be changed
// When --from-config is used, only execution-related flags are allowed
// Execution-related flags control HOW to run (foreground vs detached)
// Configuration flags control WHAT to run and should not be mixed with --from-config
allowedFlags := map[string]bool{
"from-config": true,
"foreground": true,
"debug": true, // Debug is also an execution flag
}

var conflictingFlags []string
cmd.Flags().VisitAll(func(flag *pflag.Flag) {
// Skip the from-config flag itself and only check flags that were changed
if flag.Name != "from-config" && flag.Changed {
// Skip allowed flags and only check flags that were changed
if !allowedFlags[flag.Name] && flag.Changed {
conflictingFlags = append(conflictingFlags, "--"+flag.Name)
}
})
Expand Down
Loading