Allow --foreground flag with --from-config
#2649
Merged
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --foreground flag is an execution-related flag that controls HOW to run the server (foreground vs detached), not a configuration flag that controls WHAT to run. The runFromConfigFile function already respects this flag, so it should be allowed alongside --from-config. This change modifies the validation logic to use an allowlist of execution-related flags (--foreground, --debug) that can be used with --from-config, while still preventing actual configuration flags from being mixed with --from-config. Fixes #2643 Co-authored-by: Chris Burns <ChrisJBurns@users.noreply.github.com>
ChrisJBurns
changed the title
--foreground flag with --from-config
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2649 +/- ##
=======================================
Coverage 55.29% 55.29%
=======================================
Files 315 315
Lines 30299 30299
=======================================
Hits 16754 16754
Misses 12076 12076
Partials 1469 1469 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JAORMX
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--foregroundflag is an execution-related flag that controls HOW to run the server (foreground vs detached), not a configuration flag that controls WHAT to run. TherunFromConfigFilefunction already respects this flag, so it should be allowed alongside--from-config.This change modifies the validation logic to use an allowlist of execution-related flags (
--foreground,--debug) that can be used with--from-config, while still preventing actual configuration flags from being mixed with--from-config.Fixes #2643
Generated with Claude Code