fix: follow up for removing not needed value on secrets

[yrobla]

No description provided.

[Copilot]

Pull request overview

This PR simplifies the header injection authentication converter by removing the intermediate header_value_env placeholder field. Previously, the converter would set this placeholder during metadata conversion and later remove it during secret resolution. The new implementation is cleaner: ConvertToMetadata only returns the header_name, and ResolveSecrets directly adds the header_value with the actual secret.

• Removed unnecessary header_value_env placeholder field from the conversion flow
• Updated tests to reflect the simplified metadata structure
• Improved comments to better explain the two-phase conversion process

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
pkg/vmcp/auth/converters/header_injection.go	Removed setting and deletion of header_value_env placeholder; updated comments to clarify that ConvertToMetadata returns minimal metadata and ResolveSecrets adds the secret value
pkg/vmcp/auth/converters/header_injection_test.go	Updated test expectations to verify only header_name is present after ConvertToMetadata, and both fields are present after ResolveSecrets

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.96%. Comparing base (3e4fd23) to head (cdee526).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2744   +/-   ##
=======================================
  Coverage   55.96%   55.96%           
=======================================
  Files         318      318           
  Lines       30677    30675    -2     
=======================================
  Hits        17168    17168           
+ Misses      12022    12020    -2     
  Partials     1487     1487           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.