Remove local incoming auth type from operator CRDs #2759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `local` authentication type uses `user.Current()` to get the OS username, which is meaningful for CLI usage but inappropriate in Kubernetes where the container user has no relation to connecting clients. This removes `local` from the CRD layer only, preserving it in pkg/vmcp for CLI use cases.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2759 +/- ##
=======================================
Coverage 56.29% 56.29%
=======================================
Files 319 319
Lines 30753 30753
=======================================
Hits 17312 17312
Misses 11953 11953
Partials 1488 1488 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yrobla
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
localauthentication type usesuser.Current()to get the OS username, which is meaningful for CLI usage but inappropriate in Kubernetes where the container user has no relation to connecting clients.This removes
localfrom the CRD layer only, preserving it in pkg/vmcp for CLI use cases.