Two minor fixes for vMCP retryDelay handling #2795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add admission-time validation for the RetryDelay field in VirtualMCPServer composite tool error handling. This ensures invalid duration formats are rejected with clear error messages instead of silently failing during conversion. Changes: - Add RetryDelay format validation in validateStepErrorHandling() - Reuse existing validateDuration() from the same package - Add tests for valid durations (5s, 1m30s) and invalid formats
Log a warning when RetryDelay duration parsing fails in the converter. This improves debugging by making it clear when an invalid duration is silently defaulting to zero, even though webhook validation should catch invalid formats at admission time.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2795 +/- ##
==========================================
+ Coverage 56.52% 56.53% +0.01%
==========================================
Files 319 319
Lines 30886 30894 +8
==========================================
+ Hits 17458 17466 +8
Misses 11924 11924
Partials 1504 1504 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JAORMX
previously approved these changes
Nov 28, 2025
Define ErrorActionAbort, ErrorActionContinue, and ErrorActionRetry constants to replace string literals in webhook validation code. This addresses a goconst linter warning about repeated string usage and improves code maintainability.
github-actions
bot
added
size/S
JAORMX
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two nits from the review, sent as follow-ups