Centralize container image references in e2e tests #2811
+62
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2811 +/- ##
=======================================
Coverage 56.53% 56.53%
=======================================
Files 319 319
Lines 30885 30885
=======================================
+ Hits 17460 17462 +2
+ Misses 11932 11930 -2
Partials 1493 1493 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Create a dedicated package for container image constants used across e2e tests to provide a single source of truth for image versions. Each image is now defined with three constants: - imageURL: base image path (unexported) - imageTag: version tag (unexported) - Image: combined reference (exported) This structure makes version updates simpler by allowing changes to only the tag constant while keeping the base URL unchanged. Updated test files: - test/e2e/telemetry_metrics_validation_e2e_test.go - test/e2e/thv-operator/virtualmcp/helpers.go - test/e2e/thv-operator/virtualmcp/virtualmcp_discovered_mode_test.go - test/e2e/thv-operator/virtualmcp/virtualmcp_inline_auth_test.go - test/e2e/thv-operator/virtualmcp/virtualmcp_tokenexchange_test.go Fixes stacklok#2786 Signed-off-by: 4t8dd <wanger.xyz@gmail.com>
4t8dd
force-pushed
the
issue-2786-centralize-e2e-images
branch
from
6c68f73 to
e98aba1
Compare
github-actions
bot
added
size/XS
Contributor
Author
|
@JAORMX could you please help rerun the CI job? I can run this command to get the image without any problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a dedicated package for container image constants used across e2e tests to provide a single source of truth for image versions.
Each image is now defined with three constants:
This structure makes version updates simpler by allowing changes to only the tag constant while keeping the base URL unchanged.
Updated test files:
Fixes #2786