Skip to content

Conversation

@jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Dec 1, 2025

client_id is only required for specific flows like token introspection with client credentials. For standard JWT validation using JWKS, only issuer and audience are needed.

This follows the same pattern as the previous change that made client_secret_env optional (d543c84).

client_id is only required for specific flows like token introspection
with client credentials. For standard JWT validation using JWKS, only
issuer and audience are needed.

This follows the same pattern as the previous change that made
client_secret_env optional (d543c84).
@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Dec 1, 2025
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.56%. Comparing base (20ecb03) to head (6ed551c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2822      +/-   ##
==========================================
+ Coverage   56.55%   56.56%   +0.01%     
==========================================
  Files         320      320              
  Lines       30874    30872       -2     
==========================================
+ Hits        17460    17462       +2     
+ Misses      11911    11908       -3     
+ Partials     1503     1502       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhrozek jhrozek merged commit 2f1c0f5 into main Dec 1, 2025
35 of 36 checks passed
@jhrozek jhrozek deleted the client_id_not_required branch December 1, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants