Skip to content

Conversation

@yrobla
Copy link
Contributor

@yrobla yrobla commented Dec 4, 2025

No description provided.

@github-actions github-actions bot added the size/L Large PR: 600-999 lines changed label Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.48%. Comparing base (a88d771) to head (702315b).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2896      +/-   ##
==========================================
- Coverage   56.52%   56.48%   -0.04%     
==========================================
  Files         322      322              
  Lines       31525    31633     +108     
==========================================
+ Hits        17818    17869      +51     
- Misses      12164    12233      +69     
+ Partials     1543     1531      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive E2E validation tests for VirtualMCPServer webhook validation. The tests verify that the Kubernetes webhook correctly rejects invalid configurations and accepts valid ones by attempting to create VirtualMCPServer resources with various invalid and valid specifications.

Key changes:

  • New test file with 812 lines covering validation scenarios for required fields, authentication, aggregation, and composite tools
  • Tests validate webhook behavior for ~30 different invalid configuration scenarios
  • Includes positive tests confirming valid minimal and complete configurations are accepted

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yrobla yrobla force-pushed the feat/add_invalid_config_tests branch from 5abcd34 to 9d50ceb Compare December 4, 2025 12:19
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/L Large PR: 600-999 lines changed labels Dec 4, 2025
@yrobla yrobla force-pushed the feat/add_invalid_config_tests branch from 9d50ceb to 702315b Compare December 4, 2025 12:24
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Dec 4, 2025
@yrobla yrobla requested a review from Copilot December 4, 2025 13:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yrobla yrobla merged commit 52ee1b7 into main Dec 5, 2025
41 checks passed
@yrobla yrobla deleted the feat/add_invalid_config_tests branch December 5, 2025 09:59
carlos-gn pushed a commit to carlos-gn/toolhive that referenced this pull request Dec 8, 2025
Co-authored-by: taskbot <taskbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Small PR: 100-299 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants