-
Notifications
You must be signed in to change notification settings - Fork 156
add validation tests to detect invalid configs #2896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2896 +/- ##
==========================================
- Coverage 56.52% 56.48% -0.04%
==========================================
Files 322 322
Lines 31525 31633 +108
==========================================
+ Hits 17818 17869 +51
- Misses 12164 12233 +69
+ Partials 1543 1531 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive E2E validation tests for VirtualMCPServer webhook validation. The tests verify that the Kubernetes webhook correctly rejects invalid configurations and accepts valid ones by attempting to create VirtualMCPServer resources with various invalid and valid specifications.
Key changes:
- New test file with 812 lines covering validation scenarios for required fields, authentication, aggregation, and composite tools
- Tests validate webhook behavior for ~30 different invalid configuration scenarios
- Includes positive tests confirming valid minimal and complete configurations are accepted
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5abcd34 to
9d50ceb
Compare
9d50ceb to
702315b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: taskbot <taskbot@users.noreply.github.com>
No description provided.