-
Notifications
You must be signed in to change notification settings - Fork 156
add examples of configuration for virtualmcp #2900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large PR Detected
This PR exceeds 1000 lines of changes and requires justification before it can be reviewed.
How to unblock this PR:
Add a section to your PR description with the following format:
## Large PR Justification
[Explain why this PR must be large, such as:]
- Generated code that cannot be split
- Large refactoring that must be atomic
- Multiple related changes that would break if separated
- Migration or data transformationAlternative:
Consider splitting this PR into smaller, focused changes (< 1000 lines each) for easier review and reduced risk.
See our Contributing Guidelines for more details.
This review will be automatically dismissed once you add the justification section.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2900 +/- ##
==========================================
- Coverage 56.34% 56.34% -0.01%
==========================================
Files 323 323
Lines 31640 31640
==========================================
- Hits 17828 17826 -2
- Misses 12287 12289 +2
Partials 1525 1525 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive configuration examples for VirtualMCPServer (vMCP), demonstrating various authentication modes, conflict resolution strategies, and composite tool workflows. The examples progress from simple to complex configurations, showing different patterns for aggregating multiple MCP backend servers.
Key Changes:
- Added 6 example YAML files covering simple, production, and advanced VirtualMCPServer configurations
- Demonstrated three conflict resolution strategies (prefix, priority, manual) for handling tool name conflicts
- Included composite tool examples (simple sequential and complex DAG-based workflows)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
vmcp_simple_discovered.yaml |
Basic VirtualMCPServer with discovered auth mode and anonymous incoming auth |
vmcp_production_full.yaml |
Production configuration with OIDC authentication, LoadBalancer service, and custom pod resources |
vmcp_inline_backend_auth.yaml |
Demonstrates inline OIDC configuration for incoming authentication with Cedar policies |
vmcp_conflict_resolution.yaml |
Shows all three conflict resolution strategies (prefix, priority, manual) side-by-side |
composite_tool_simple.yaml |
Simple composite tool with sequential steps and dependency management |
composite_tool_complex.yaml |
Advanced composite tool with parallel execution, conditional logic, and complex workflows |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Large PR justification has been provided. Thank you!
|
✅ Large PR justification has been provided. The size review has been dismissed and this PR can now proceed with normal review. |
a8c164d to
a83047c
Compare
|
merging as it's not changing any code and the failures are not related |
* add examples of configuration for virtualmcp * fixes from review --------- Co-authored-by: taskbot <taskbot@users.noreply.github.com> Co-authored-by: Don Browne <dmjb@users.noreply.github.com>
Large PR Justification
This PR contains a complete set fo examples on how to configure virtualmcp. The size of the PR is huge because it's a compilation of all possible configurations.