Fix VirtualMCPServer controller to check PodReady condition #2901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VirtualMCPServer controller was marking the CR as Ready based on pod.Status.Phase == PodRunning, but this doesn't guarantee the pod is actually ready to serve traffic. A pod can be in Running phase while still waiting for its readiness probe to pass. This caused flaky E2E tests where: 1. Pod starts → Phase becomes Running 2. Controller sees Running → marks CR as Ready 3. Test sees CR Ready → tries to connect 4. Pod hasn't passed readiness probe → EOF error Now the controller checks the PodReady condition in pod.Status.Conditions, which is the authoritative signal that a pod can receive traffic. This aligns with Kubernetes semantics and ensures the VirtualMCPServer is only marked Ready when the underlying HTTP server is actually responding. Changes: - Check PodReady condition instead of PodRunning phase - Rename 'running' counter to 'ready' for clarity - Add test case for "running but not ready" pods - Update existing test to set PodReady condition 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2901 +/- ##
==========================================
+ Coverage 56.41% 56.42% +0.01%
==========================================
Files 322 322
Lines 31638 31644 +6
==========================================
+ Hits 17848 17856 +8
+ Misses 12252 12250 -2
Partials 1538 1538 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ChrisJBurns
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PodReadycondition instead ofPodRunningphaseProblem
The VirtualMCPServer controller was marking the CR as Ready based on
pod.Status.Phase == PodRunning, but this doesn't guarantee the pod is actually ready to serve traffic. A pod can be in Running phase while still waiting for its readiness probe to pass.This caused flaky E2E tests where:
RunningRunning→ marks CR asReadyReady→ tries to connectSolution
Now the controller checks the
PodReadycondition inpod.Status.Conditions, which is the authoritative signal that a pod can receive traffic. This aligns with Kubernetes semantics.PodReadycondition =TruePodFailedphaseTest plan
go test ./cmd/thv-operator/controllers/... -run VirtualMCPServer)task lint)🤖 Generated with Claude Code