-
Notifications
You must be signed in to change notification settings - Fork 156
Ensure PID files are cleaned up after migration #2905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Now that we now longer create PID files for new workloads, ensure they get cleaned up during the status migration process.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2905 +/- ##
=======================================
Coverage 56.36% 56.36%
=======================================
Files 323 323
Lines 31764 31763 -1
=======================================
Hits 17904 17904
+ Misses 12331 12330 -1
Partials 1529 1529 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The e2e test failures are strange since they should never hit this codepath. Will investigate this when I get the chance. |
Now that we now longer create PID files for new workloads, ensure they get cleaned up during the status migration process.
Now that we now longer create PID files for new workloads, ensure they get cleaned up during the status migration process.