Skip to content

Conversation

@dmjb
Copy link
Member

@dmjb dmjb commented Dec 4, 2025

Now that we now longer create PID files for new workloads, ensure they get cleaned up during the status migration process.

Now that we now longer create PID files for new workloads, ensure they
get cleaned up during the status migration process.
@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Dec 4, 2025
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.36%. Comparing base (b34f7d3) to head (6dd746f).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
pkg/workloads/statuses/file_status.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2905   +/-   ##
=======================================
  Coverage   56.36%   56.36%           
=======================================
  Files         323      323           
  Lines       31764    31763    -1     
=======================================
  Hits        17904    17904           
+ Misses      12331    12330    -1     
  Partials     1529     1529           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmjb
Copy link
Member Author

dmjb commented Dec 4, 2025

The e2e test failures are strange since they should never hit this codepath. Will investigate this when I get the chance.

@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Dec 5, 2025
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Dec 5, 2025
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Dec 5, 2025
@dmjb dmjb merged commit afe9b41 into main Dec 5, 2025
33 checks passed
@dmjb dmjb deleted the cleanup-pid-after-migration branch December 5, 2025 13:56
carlos-gn pushed a commit to carlos-gn/toolhive that referenced this pull request Dec 8, 2025
Now that we now longer create PID files for new workloads, ensure they
get cleaned up during the status migration process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants