Refactor CRD Telemetry Config Conversion for Reusability

[jerm-dro]

Summary

This pull request refactors the existing logic of AddTelemetryConfigOptions so the conversion from mcpv1alpha1.TelemetryConfig to telemetry.Config is reusable without having to create a RunConfigBuilderOption.

I'd like to reuse just this conversion logic within #2906, so the vMCP CRD uses the same exact telemetry type as the MCP Proxy, etc.

This PR isn't small but it's mostly just moving code to places that make it more composable.

Implementation Details

• Moved the telemetry.Config construction logic that was within WithTelemetryConfig to telemetry.MaybeMakeConfig.
• Renamed WithTelemetryConfig to WithTelemetryConfigFlags which behaves just as before.
• Created WithTelemetryConfig which just assign the given telemetry config.
• Created spectoconfig/telemetry.go (pronounced "Spec To Config" other names welcome) which contains ConvertTelemetryConfig. ConvertTelemetryConfig is exactly the same as AddTelemetryConfigOptions minus creating the option.

[codecov]

Codecov Report

❌ Patch coverage is 20.00000% with 76 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.26%. Comparing base (55d0cee) to head (0899abd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/thv-operator/pkg/spectoconfig/telemetry.go	0.00%	47 Missing ⚠️
pkg/telemetry/config.go	0.00%	29 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2908      +/-   ##
==========================================
- Coverage   56.39%   56.26%   -0.14%     
==========================================
  Files         322      323       +1     
  Lines       31622    31640      +18     
==========================================
- Hits        17834    17801      -33     
- Misses      12257    12308      +51     
  Partials     1531     1531              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

This PR refactors telemetry configuration conversion logic to improve code reusability. It extracts the conversion logic from WithTelemetryConfig into standalone functions (MaybeMakeConfig and ConvertTelemetryConfig) that can be used independently, particularly for integration with the vMCP CRD in PR #2906.

Key changes:

• Created telemetry.MaybeMakeConfig() to handle the core telemetry config construction logic from individual parameters
• Renamed WithTelemetryConfig() to WithTelemetryConfigFromFlags() and created a new WithTelemetryConfig() that accepts a pre-built config
• Introduced spectoconfig package with ConvertTelemetryConfig() to convert CRD TelemetryConfig to telemetry.Config

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pkg/telemetry/config.go	Added MaybeMakeConfig() function to create telemetry configuration from individual parameters
pkg/runner/config_builder.go	Renamed WithTelemetryConfig to WithTelemetryConfigFromFlags, created new WithTelemetryConfig that accepts config directly
cmd/thv-operator/pkg/spectoconfig/telemetry.go	New package/file containing ConvertTelemetryConfig() to convert CRD types to telemetry.Config
cmd/thv-operator/pkg/runconfig/telemetry.go	Simplified to use spectoconfig.ConvertTelemetryConfig() instead of inline conversion logic
pkg/runner/config_test.go	Updated all test calls from WithTelemetryConfig to WithTelemetryConfigFromFlags
pkg/api/v1/workload_service.go	Updated function call to use WithTelemetryConfigFromFlags
cmd/thv/app/run_flags.go	Updated function call to use WithTelemetryConfigFromFlags

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.