-
Notifications
You must be signed in to change notification settings - Fork 156
add test for composite workflow by reference #2956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2956 +/- ##
=======================================
Coverage 56.02% 56.02%
=======================================
Files 328 328
Lines 32342 32342
=======================================
Hits 18120 18120
Misses 12676 12676
Partials 1546 1546 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds an E2E test for composite workflow functionality using referenced VirtualMCPCompositeToolDefinition resources rather than inline definitions. This test validates that composite tools can be defined separately as reusable resources and then referenced by VirtualMCPServer instances using CompositeToolRefs.
Key changes:
- Adds a new test file that validates composite tool definition by reference
- Tests creation, validation, and execution of referenced composite workflows
- Verifies proper status conditions and resource configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
test/e2e/thv-operator/virtualmcp/virtualmcp_composite_referenced_test.go
Outdated
Show resolved
Hide resolved
1f5a7c0 to
d7d7c01
Compare
d7d7c01 to
4ac5022
Compare
4ac5022 to
7970c58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
test/e2e/thv-operator/virtualmcp/virtualmcp_composite_referenced_test.go
Outdated
Show resolved
Hide resolved
test/e2e/thv-operator/virtualmcp/virtualmcp_composite_referenced_test.go
Outdated
Show resolved
Hide resolved
test/e2e/thv-operator/virtualmcp/virtualmcp_composite_referenced_test.go
Outdated
Show resolved
Hide resolved
test/e2e/thv-operator/virtualmcp/virtualmcp_composite_referenced_test.go
Outdated
Show resolved
Hide resolved
7970c58 to
625e33d
Compare
No description provided.