Skip to content

Conversation

@rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented Dec 9, 2025

The following PR aims to fix 2 issues:

  • the API server was returned a cached version of the registry (changes via the API were made available after the server restarted)
  • the auto-detection logic was wrongly relying on an /openapi spec being served, so this simplifies it

@rdimitrov rdimitrov changed the title Fix registry Simplify the registry auto-detection Dec 9, 2025
@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 59.21053% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.12%. Comparing base (147d5f5) to head (95ff645).

Files with missing lines Patch % Lines
pkg/config/registry.go 67.85% 9 Missing and 9 partials ⚠️
pkg/api/v1/registry.go 55.55% 3 Missing and 1 partial ⚠️
pkg/registry/api/client.go 0.00% 4 Missing ⚠️
pkg/registry/provider_api.go 0.00% 3 Missing ⚠️
pkg/registry/provider_remote.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2976      +/-   ##
==========================================
+ Coverage   56.09%   56.12%   +0.03%     
==========================================
  Files         328      328              
  Lines       32376    32425      +49     
==========================================
+ Hits        18160    18200      +40     
+ Misses      12676    12671       -5     
- Partials     1540     1554      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed size/S Small PR: 100-299 lines changed and removed size/XS Extra small PR: < 100 lines changed size/S Small PR: 100-299 lines changed labels Dec 10, 2025
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Dec 10, 2025
@github-actions github-actions bot added size/M Medium PR: 300-599 lines changed and removed size/S Small PR: 100-299 lines changed size/M Medium PR: 300-599 lines changed labels Dec 10, 2025
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
…rmat

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@github-actions github-actions bot removed the size/M Medium PR: 300-599 lines changed label Dec 10, 2025
@github-actions github-actions bot added size/M Medium PR: 300-599 lines changed and removed size/M Medium PR: 300-599 lines changed labels Dec 10, 2025
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@github-actions github-actions bot added size/M Medium PR: 300-599 lines changed and removed size/M Medium PR: 300-599 lines changed labels Dec 10, 2025
@rdimitrov rdimitrov marked this pull request as ready for review December 10, 2025 16:54
@github-actions github-actions bot added size/M Medium PR: 300-599 lines changed and removed size/M Medium PR: 300-599 lines changed labels Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Medium PR: 300-599 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants