Fix VirtualMCP e2e test port accessibility checks #2978
+98
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2978 +/- ##
==========================================
+ Coverage 56.02% 56.08% +0.06%
==========================================
Files 328 328
Lines 32342 32373 +31
==========================================
+ Hits 18120 18158 +38
+ Misses 12676 12675 -1
+ Partials 1546 1540 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances e2e test reliability by adding port accessibility checks before attempting MCP client connections. The changes address EOF errors that occurred when tests tried to connect to services before the underlying pods were fully ready to accept connections.
Key Changes
- Added pod readiness verification within
WaitForVirtualMCPServerReadyto ensure pods are running and ready, not just checking CRD status - Added TCP port accessibility check in
GetVMCPNodePortto verify the NodePort is actually listening before returning - Introduced helper functions
checkPodsReadyandcheckPortOpento support the enhanced verification
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yrobla
force-pushed
the
fix_e2e_lifecycle_tests
branch
from
87434ee to
97e5c76
Compare
github-actions
bot
added
size/S
Enhance test helpers to verify MCP server is actually listening before attempting client connections, preventing EOF errors. The original helpers only checked Kubernetes resource status (Ready condition and NodePort assignment) but didn't verify the actual pods were running or the port was accessible. This timing gap caused tests to fail with EOF errors when connecting to localhost:30020.
yrobla
force-pushed
the
fix_e2e_lifecycle_tests
branch
from
97e5c76 to
05d05f9
Compare
github-actions
bot
added
size/S
JAORMX
previously approved these changes
Dec 10, 2025
github-actions
bot
added
size/S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance test helpers to verify MCP server is actually listening before attempting client connections, preventing EOF errors.
The original helpers only checked Kubernetes resource status (Ready condition and NodePort assignment) but didn't verify the actual pods were running or the port was accessible. This timing gap caused tests to fail with EOF errors when connecting.