Pass debug flag to detached process restart command #2992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running a workload in detached mode with debug enabled, the debug flag was not being passed to the spawned restart command. This meant debug logging was lost after the handoff to the detached process. Signed-off-by: carlos <21148423+carlos-gn@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2992 +/- ##
==========================================
- Coverage 56.18% 56.17% -0.01%
==========================================
Files 330 330
Lines 32455 32457 +2
==========================================
Hits 18234 18234
- Misses 12673 12674 +1
- Partials 1548 1549 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
size/XS
eleftherias
approved these changes
Dec 11, 2025
github-actions
bot
added
size/XS
Member
|
Thanks @carlos-gn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When running a workload in detached mode with debug enabled, the debug flag was not being passed to the spawned restart command. This meant debug logging was lost after the handoff to the detached process.
Fixes: #2938 (comment)