Skip to content

Conversation

@jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Jan 19, 2026

As I'm going through the motions of plugging in the upstream proxy providers into the authproxy "frontend", I'm noticing things in the upstream code that could be simplified. This is one of them.

Replace hand-rolled redirect URI validation with fosite functions. This is our own callback URL where upstream IDPs redirect back to us - the upstream IDP validates it against their registered URIs anyway.

This aligns with the DCR package which already uses fosite for the same purpose.

Replace hand-rolled redirect URI validation with fosite functions.
This is our own callback URL where upstream IDPs redirect back to us -
the upstream IDP validates it against their registered URIs anyway.

This aligns with the DCR package which already uses fosite for the same purpose.
@github-actions github-actions bot added the size/S Small PR: 100-299 lines changed label Jan 19, 2026
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.65%. Comparing base (a5a7d48) to head (dd77937).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/authserver/upstream/oauth2.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3339      +/-   ##
==========================================
- Coverage   64.68%   64.65%   -0.03%     
==========================================
  Files         369      369              
  Lines       35963    35956       -7     
==========================================
- Hits        23264    23249      -15     
- Misses      10868    10877       +9     
+ Partials     1831     1830       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhrozek jhrozek merged commit 6d2013a into main Jan 19, 2026
43 of 44 checks passed
@jhrozek jhrozek deleted the oauth-proxy-simple-redirect-check branch January 19, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Small PR: 100-299 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants