Skip to content

Conversation

@dmjb
Copy link
Member

@dmjb dmjb commented Jan 27, 2026

Previously they were added, then disabled due to problems which were encountered in the wild. Allow them to be turned on with the TOOLHIVE_REMOTE_HEALTHCHECK env var. This approach was taken instead of adding variables to the CLI, API and run config since we want to make them mandatory in future, and I want to avoid adding options which will be redundant later.

Previously they were added, then disabled due to problems which were
encountered in the wild. Allow them to be turned on with the
TOOLHIVE_REMOTE_HEALTHCHECK env var. This approach was taken instead of
adding variables to the CLI, API and run config since we want to make
them mandatory in future, and I want to avoid adding options which will
be redundant later.
@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Jan 27, 2026
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.90%. Comparing base (e6d3bde) to head (830a7a1).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/transport/http.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3462      +/-   ##
==========================================
- Coverage   64.90%   64.90%   -0.01%     
==========================================
  Files         394      394              
  Lines       38402    38408       +6     
==========================================
+ Hits        24926    24929       +3     
- Misses      11530    11533       +3     
  Partials     1946     1946              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

lujunsan
lujunsan previously approved these changes Jan 27, 2026
amirejaz
amirejaz previously approved these changes Jan 27, 2026
@dmjb dmjb dismissed stale reviews from amirejaz and lujunsan via 830a7a1 January 27, 2026 15:30
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Jan 27, 2026
@dmjb dmjb merged commit b3e0ef8 into main Jan 27, 2026
35 checks passed
@dmjb dmjb deleted the remote-health-checks branch January 27, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Small PR: 100-299 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants