[WIP] Add E2E tests for secrets management #3485
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/L
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3485 +/- ##
==========================================
+ Coverage 65.15% 65.24% +0.08%
==========================================
Files 398 399 +1
Lines 38821 38908 +87
==========================================
+ Hits 25295 25385 +90
+ Misses 11564 11557 -7
- Partials 1962 1966 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dmjb
force-pushed
the
api-e2e-phase-viii
branch
from
fb44083 to
a910ab4
Compare
dmjb
force-pushed
the
api-e2e-phase-viii
branch
from
a910ab4 to
4da9af4
Compare
github-actions
bot
added
size/M
dmjb
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
eleftherias,
jhrozek,
lujunsan,
rdimitrov and
yrobla
as code owners
eleftherias
reviewed
Jan 28, 2026
Member
eleftherias
left a comment
eleftherias
left a comment
There was a problem hiding this comment.
The 404 tests are failing with a 405. Also added one question inline.
| defer resp.Body.Close() | ||
|
|
||
| By("Verifying response status is 400 or 405") | ||
| Expect(resp.StatusCode).To(SatisfyAny( |
Member
There was a problem hiding this comment.
Is it possible that it'll return 2 different status codes today, or is this for future-proofing?
dmjb
changed the title
github-actions
bot
added
size/M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to dependency issues (keychain for encrypted, or 1password), these tests only test the environment type. This does not cover all secrets management functionality, but verifies basic correctness of the secrets endpoints.