Skip to content

chore: cache go build/tools in helm charts workflow#3559

Closed
slyt3 wants to merge 3 commits intostacklok:mainfrom
slyt3:ci-workflow-updates
Closed

chore: cache go build/tools in helm charts workflow#3559
slyt3 wants to merge 3 commits intostacklok:mainfrom
slyt3:ci-workflow-updates

Conversation

@slyt3
Copy link
Contributor

@slyt3 slyt3 commented Feb 2, 2026

PR, as requested in #3257, it will add go build + go tools cache to the current helm-chart-test.yml workflow (the old Heml lint/test workflows were removed upstream)

@dmjb

@slyt3 slyt3 requested a review from JAORMX as a code owner February 2, 2026 19:44
@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Feb 2, 2026
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Feb 4, 2026
@ChrisJBurns
Copy link
Collaborator

@slyt3 Thanks for this PR. Are you sure we need this? Looking at a CI run for this action without this change, the steps that take the most time is the setting up of the Kind cluster and the running of the tests themselves. There doesn't seem to be any need for caching any go modules? The CI run for this PR seems to be a bit longer too so I'm more convinced now that we may not need this caching.

What do you think?

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.53%. Comparing base (e9417b6) to head (6659498).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3559      +/-   ##
==========================================
- Coverage   65.60%   65.53%   -0.07%     
==========================================
  Files         406      406              
  Lines       40083    40083              
==========================================
- Hits        26295    26270      -25     
- Misses      11744    11770      +26     
+ Partials     2044     2043       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Feb 4, 2026
@slyt3
Copy link
Contributor Author

slyt3 commented Feb 4, 2026

@ChrisJBurns I reran and compared step timings; its like now its few seconds faster the long steps (~1m49s and ~2m) are unchanged, and the small steps vary by only a few seconds; yea you right I dont see a clear improvement from the cache, so I’m OK to drop this PR

@ChrisJBurns
Copy link
Collaborator

@slyt3 Yep no problems, I'll close this PR. Thanks for the idea though, we could always use more of the "how to make this better" mindset! ❤️

@ChrisJBurns ChrisJBurns closed this Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants