chore: cache go build/tools in helm charts workflow#3559
chore: cache go build/tools in helm charts workflow#3559slyt3 wants to merge 3 commits intostacklok:mainfrom
Conversation
|
@slyt3 Thanks for this PR. Are you sure we need this? Looking at a CI run for this action without this change, the steps that take the most time is the setting up of the Kind cluster and the running of the tests themselves. There doesn't seem to be any need for caching any go modules? The CI run for this PR seems to be a bit longer too so I'm more convinced now that we may not need this caching. What do you think? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3559 +/- ##
==========================================
- Coverage 65.60% 65.53% -0.07%
==========================================
Files 406 406
Lines 40083 40083
==========================================
- Hits 26295 26270 -25
- Misses 11744 11770 +26
+ Partials 2044 2043 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@ChrisJBurns I reran and compared step timings; its like now its few seconds faster the long steps (~1m49s and ~2m) are unchanged, and the small steps vary by only a few seconds; yea you right I dont see a clear improvement from the cache, so I’m OK to drop this PR |
|
@slyt3 Yep no problems, I'll close this PR. Thanks for the idea though, we could always use more of the "how to make this better" mindset! ❤️ |
PR, as requested in #3257, it will add go build + go tools cache to the current helm-chart-test.yml workflow (the old Heml lint/test workflows were removed upstream)
@dmjb