Ensure API E2E tests clean up after themselves #3588
+159
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmjb
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
eleftherias,
jhrozek,
lujunsan,
rdimitrov and
yrobla
as code owners
rdimitrov
previously approved these changes
Feb 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3588 +/- ##
==========================================
+ Coverage 65.51% 65.57% +0.06%
==========================================
Files 406 406
Lines 39996 39996
==========================================
+ Hits 26202 26227 +25
+ Misses 11762 11737 -25
Partials 2032 2032 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
size/S
The code previously relied on API calls to clean up local test state. However, since the APIs are async, and the servers get spun up and down during the tests, a lot of workloads would end up in a partially deleted state. This change uses the CLI for final cleanup, ensuring that the cleanup is complete. This mostly affects local runs of the E2E tests.
Recently, a PR was created which called the PID file logic. The PID file logic is deprecated, and only used to handle workloads created by old versions of ToolHive. As a precaution, move the PID file logic into the statuses package, and make it private, so that the PID file handling occurs inside the status file logic.
dmjb
force-pushed
the
api-e2e-state-cleanup
branch
from
15002a3 to
9808e1a
Compare
github-actions
bot
added
size/S
github-actions
bot
added
size/S
github-actions
bot
added
size/S
github-actions
bot
added
size/S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code previously relied on API calls to clean up local test state. However, since the APIs are async, and the servers get spun up and down during the tests, a lot of workloads would end up in a partially deleted state. This change uses the CLI for final cleanup, ensuring that the cleanup is complete. In tests where delete endpoints are tested, it introduces some logic to wait for the deletion to finish.
This mostly affects local runs of the E2E tests.