Enable OIDC provider support in the embedded auth server #3720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the embedded auth server converted all upstream configs to OAuth2Config, which meant OIDCProviderImpl was never instantiated even when the upstream was configured as type "oidc". This caused OIDC features like ID token validation and automatic discovery to be silently skipped.
Refactor UpstreamConfig to carry an explicit provider type ("oidc" or "oauth2") with separate OIDCConfig and OAuth2Config fields. The upstream factory now dispatches on type, creating OIDCProviderImpl (with OIDC discovery and ID token validation) for OIDC upstreams and BaseOAuth2Provider for OAuth2 upstreams. Config validation enforces mutual exclusivity between the two config fields.
Tested end-to-end with Google as the OIDC upstream:
Fixes: https://github.com/stacklok/stacklok-epics/issues/235