Add vector embedding support and hybrid search to ToolStore #3808
+1,120
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aponcedeleonch
requested review from
JAORMX,
amirejaz,
jerm-dro,
jhrozek and
yrobla
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Large PR Detected
This PR exceeds 1000 lines of changes and requires justification before it can be reviewed.
How to unblock this PR:
Add a section to your PR description with the following format:
## Large PR Justification
[Explain why this PR must be large, such as:]
- Generated code that cannot be split
- Large refactoring that must be atomic
- Multiple related changes that would break if separated
- Migration or data transformationAlternative:
Consider splitting this PR into smaller, focused changes (< 1000 lines each) for easier review and reduced risk.
See our Contributing Guidelines for more details.
This review will be automatically dismissed once you add the justification section.
aponcedeleonch
force-pushed
the
issue-3732/semantic-search-store
branch
from
c06effa to
5d93afe
Compare
github-actions
bot
added
size/XL
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3808 +/- ##
==========================================
+ Coverage 66.84% 66.91% +0.07%
==========================================
Files 439 441 +2
Lines 43509 43660 +151
==========================================
+ Hits 29083 29216 +133
- Misses 12175 12182 +7
- Partials 2251 2262 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aponcedeleonch
force-pushed
the
issue-3731/sqlite-fts5-store
branch
from
631f1d6 to
85a4c84
Compare
jerm-dro
reviewed
Feb 12, 2026
Contributor
jerm-dro
left a comment
jerm-dro
left a comment
There was a problem hiding this comment.
The diff is quite large due to the conflicts with the base branch. The structure looks good, but I will take a closer look when the base branch is merged.
aponcedeleonch
force-pushed
the
issue-3732/semantic-search-store
branch
from
5d93afe to
0fa9e53
Compare
github-actions
bot
added
size/XL
github-actions
bot
dismissed
their stale review
Large PR justification has been provided. Thank you!
Contributor
|
✅ Large PR justification has been provided. The size review has been dismissed and this PR can now proceed with normal review. |
aponcedeleonch
force-pushed
the
issue-3732/semantic-search-store
branch
from
0fa9e53 to
d17bbb0
Compare
github-actions
bot
added
size/XL
aponcedeleonch
force-pushed
the
issue-3732/semantic-search-store
branch
from
d17bbb0 to
53657a3
Compare
github-actions
bot
added
size/XL
aponcedeleonch
force-pushed
the
issue-3732/semantic-search-store
branch
from
53657a3 to
39ad0e2
Compare
yrobla
reviewed
Feb 13, 2026
yrobla
reviewed
Feb 13, 2026
Extend the SQLite-backed ToolStore with optional embedding-based semantic search. When an EmbeddingClient is provided, Search runs FTS5 and cosine similarity in parallel via errgroup, merges and deduplicates results by keeping the lower distance score, and caps output at 4 results. Key additions: - EmbeddingClient interface in internal/types (Embed, EmbedBatch, Dimension, Close) - FakeEmbeddingClient using SHA-256 seeded RNG with L2-normalized vectors - Pure Go cosine similarity/distance in internal/similarity package - Binary encode/decode helpers for embedding BLOB storage - normalizeBM25 rescaled to [0, 2) range to align with cosine distance - Comprehensive unit tests, concurrency tests, and benchmarks Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
aponcedeleonch
force-pushed
the
issue-3732/semantic-search-store
branch
from
39ad0e2 to
09908e0
Compare
github-actions
bot
added
size/XL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3732
Extend the SQLite-backed ToolStore with optional embedding-based semantic search. When an EmbeddingClient is provided, Search runs FTS5 and cosine similarity in parallel via errgroup, merges and deduplicates results by keeping the lower distance score, and caps output at 4 results.
Key additions:
Large PR Justification