Validate OCI tags from all sources in Build (follow up to 3894)#3897
Open
Validate OCI tags from all sources in Build (follow up to 3894)#3897
Conversation
Move tag validation after tag computation so both explicit user-provided tags and config-name fallback tags are validated against the OCI distribution spec. Previously only the explicit opts.Tag was checked, leaving the config name path unvalidated. Also add debug logging for Push Resolve failures to aid diagnostics without leaking internal paths to API clients.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3897 +/- ##
==========================================
+ Coverage 66.85% 66.90% +0.04%
==========================================
Files 444 444
Lines 44630 44631 +1
==========================================
+ Hits 29839 29859 +20
+ Misses 12461 12442 -19
Partials 2330 2330 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was Johnny-came-late again for #3894 so I'm sending my comments as a follow-up.
Move tag validation after tag computation so both explicit user-provided tags and config-name fallback tags are validated against the OCI distribution spec. Previously only the explicit opts.Tag was checked, leaving the config name path unvalidated.
Also add debug logging for Push Resolve failures to aid diagnostics without leaking internal paths to API clients.