Implement skills REST handlers with project_root#3911
Merged
Conversation
project_root
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3911 +/- ##
==========================================
+ Coverage 67.76% 67.83% +0.06%
==========================================
Files 439 440 +1
Lines 44130 44229 +99
==========================================
+ Hits 29905 30001 +96
- Misses 11881 11885 +4
+ Partials 2344 2343 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
reyortiz3
reviewed
Feb 20, 2026
Collaborator
Author
|
@claude could you fix the listing errors? |
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
0efac8f to
c392bc5
Compare
c392bc5 to
3051750
Compare
jhrozek
previously approved these changes
Mar 2, 2026
Contributor
jhrozek
left a comment
There was a problem hiding this comment.
LGTM — solid validation with good defense-in-depth. One minor nit left as an inline comment.
Add client/project_root filters to skills listing and enforce strict project root validation, including git repository checks, across list/install/uninstall/info. Update tests and swagger docs to match.
Reject symlinked project_root paths and centralize scope/project_root normalization in skills to keep API thin and reuse service validation. Update API tests for service-driven validation errors.
092863d to
3c4a0b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clientandproject_rootRationale
Issue
Reviewer Notes
scope=projectis used withoutproject_root, or when project_root fails validationproject_root; list also acceptsclientdocs/server/*Testing