Fix remote workload restart port bind error when unauthenticated#3975
Open
Fix remote workload restart port bind error when unauthenticated#3975
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3975 +/- ##
==========================================
- Coverage 68.44% 68.43% -0.01%
==========================================
Files 437 437
Lines 44363 44362 -1
==========================================
- Hits 30363 30358 -5
- Misses 11632 11636 +4
Partials 2368 2368 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
The changes make sense. I'll wait for the PR checks to be green before approving. It looks like there's a flaky tests causing a failure now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a remote workload becomes unauthenticated (e.g., token refresh fails when the laptop disconnects from the internet), the proxy process continues running and holding the port. If the user runs
thv restart, it fails with "port already in use" because we never stopped the existing proxy before attempting to start a new one.Solution
Stop proxy before restart: Always call
stopProxyIfNeededbefore loading config and starting a new runner for any restart path.Unified restart flow: Consolidate the restart logic for all remote workload states (Running+dead, Unauthenticated, Unhealthy, Error). The flow now:
This removes special handling for Running+dead and keeps status consistent with reality.
Changes
maybeSetupRemoteWorkloadto use the unified restart flow.Testing
Unit tests updated and passing. Covers: