Skip to content

Implement skill list and info CLI commands with shared helpers#3987

Merged
JAORMX merged 1 commit intomainfrom
skill-cli-read-commands
Mar 4, 2026
Merged

Implement skill list and info CLI commands with shared helpers#3987
JAORMX merged 1 commit intomainfrom
skill-cli-read-commands

Conversation

@JAORMX
Copy link
Collaborator

@JAORMX JAORMX commented Mar 4, 2026

Summary

  • Add skill_helpers.go with shared utilities (newSkillClient, completeSkillNames, formatSkillError, validateSkillScope) used across all skill commands
  • Replace empty skill list and skill info stubs with real implementations that call the Skills HTTP client
  • Add "skill" to the informationalCommands map since skill commands communicate via HTTP API, not container runtime
  • skill list supports --scope, --client, --format, --project-root flags with text (tabwriter) and JSON output
  • skill info supports --scope, --format, --project-root flags with detailed key-value text and JSON output, plus shell completion for skill names

Part 1 of 3 for #3653 (CLI Skills Commands).

Test plan

  • task lint passes with no new warnings
  • task test passes (existing unit tests)
  • task license-check passes (SPDX headers correct)
  • thv skill --help shows all subcommands
  • thv skill list --help shows correct flags (--scope, --client, --format, --project-root)
  • thv skill info --help shows correct flags (--scope, --format, --project-root)

🤖 Generated with Claude Code

Add skill_helpers.go with shared utilities (newSkillClient, completeSkillNames,
formatSkillError, validateSkillScope) and replace the empty skill list/info
stubs with real implementations that call the Skills HTTP client.

Also add "skill" to the informationalCommands map since skill commands
communicate with the HTTP API, not the container runtime.

Closes #3653

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions github-actions bot added the size/S Small PR: 100-299 lines changed label Mar 4, 2026
@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.55%. Comparing base (c46ae47) to head (94313b4).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3987      +/-   ##
==========================================
- Coverage   68.56%   68.55%   -0.01%     
==========================================
  Files         437      437              
  Lines       44662    44662              
==========================================
- Hits        30621    30617       -4     
- Misses      11657    11663       +6     
+ Partials     2384     2382       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@aponcedeleonch aponcedeleonch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@JAORMX JAORMX merged commit 8203caa into main Mar 4, 2026
33 checks passed
@JAORMX JAORMX deleted the skill-cli-read-commands branch March 4, 2026 09:54
reyortiz3 pushed a commit that referenced this pull request Mar 4, 2026
Add skill_helpers.go with shared utilities (newSkillClient, completeSkillNames,
formatSkillError, validateSkillScope) and replace the empty skill list/info
stubs with real implementations that call the Skills HTTP client.

Also add "skill" to the informationalCommands map since skill commands
communicate with the HTTP API, not the container runtime.

Closes #3653

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Small PR: 100-299 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants