Remove invalid 'apply' RBAC verb from operator roles#4001
Merged
ChrisJBurns merged 9 commits intomainfrom Mar 5, 2026
Merged
Conversation
The 'apply' string is not a valid Kubernetes RBAC verb. Server-side apply uses the 'patch' verb (HTTP PATCH with application/apply-patch+yaml), which is already present in all affected rules. The 'apply' verb was silently accepted by the API server but never matched any real request. Closes #3995 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ChrisJBurns
requested review from
JAORMX,
jerm-dro,
jhrozek and
yrobla
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4001 +/- ##
==========================================
+ Coverage 68.52% 68.59% +0.07%
==========================================
Files 441 441
Lines 44970 44970
==========================================
+ Hits 30814 30847 +33
+ Misses 11763 11730 -33
Partials 2393 2393 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
size/XS
github-actions
bot
added
size/XS
github-actions
bot
added
size/XS
github-actions
bot
added
size/XS
JAORMX
previously approved these changes
Mar 5, 2026
github-actions
bot
added
size/XS
Signed-off-by: Chris Burns <29541485+ChrisJBurns@users.noreply.github.com>
…toolhive into remove-invalid-apply-rbac-verb
github-actions
bot
added
size/XS
github-actions
bot
added
size/XS
jhrozek
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applyRBAC verb from all operator controller kubebuilder markers,defaultRBACRules, generated ClusterRole manifest, and Chainsaw test assertionsapplyis not a valid Kubernetes RBAC verb — server-side apply uses thepatchverb (already present in all rules), so theapplyentry was a silent no-op stored in etcdCloses #3995
Test plan
go test ./cmd/thv-operator/controllers/...)applyverb remains in RBAC-related files🤖 Generated with Claude Code