Remove non-spec progress/update method from MCP parser#4188
Open
majiayu000 wants to merge 1 commit intostacklok:mainfrom
Open
Remove non-spec progress/update method from MCP parser#4188majiayu000 wants to merge 1 commit intostacklok:mainfrom
majiayu000 wants to merge 1 commit intostacklok:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4188 +/- ##
==========================================
- Coverage 69.28% 69.19% -0.10%
==========================================
Files 464 464
Lines 46639 46641 +2
==========================================
- Hits 32312 32271 -41
- Misses 11851 11856 +5
- Partials 2476 2514 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The 'progress/update' method is not part of the MCP specification. The spec-compliant 'notifications/progress' handler already exists and correctly handles progress notifications. Remove 'progress/update' from the parser method handlers, authz middleware method map, and the authorization skip list, along with its dead handler function and associated test cases. Closes stacklok#4170 Signed-off-by: majiayu000 <1835304752@qq.com>
majiayu000
force-pushed
the
fix/issue-4170-remove-non-spec-progress-update
branch
from
310273a to
d046133
Compare
github-actions
bot
added
size/XS
majiayu000
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
blkt,
jhrozek and
yrobla
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MCP parser included a
progress/updatemethod handler that is not part of the MCP specification. This conflicts with the spec-compliantnotifications/progresshandler that already exists and works correctly. Removing the non-spec method to align with the protocol specification.progress/updatemap entry and deadhandleProgressMethodfunction from parserprogress/updatefrom authorization middleware (method map and skip-auth condition)Fixes #4170
Type of change
Test plan
task test)task lint-fix)Ran
go test ./pkg/mcp/... ./pkg/authz/...— all tests pass. Verifiedgo build ./...compiles cleanly.