Fix release workflow: cosign-installer upgrade and re-run support#4244
Merged
Fix release workflow: cosign-installer upgrade and re-run support#4244
Conversation
JAORMX
approved these changes
Mar 19, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4244 +/- ##
=======================================
Coverage 69.11% 69.12%
=======================================
Files 470 470
Lines 47387 47387
=======================================
+ Hits 32752 32754 +2
+ Misses 12091 12090 -1
+ Partials 2544 2543 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release workflow was failing due to (1) cosign-installer v3.10.1 using an older cosign that did not meet the >= 2.6.0 requirement, and (2) re-runs failing with "assets already exist" when GoReleaser tried to upload to a release that already had assets from a partial run.
Fix:
helm-publish.ymland the proxyrunner job inimage-build-and-publish.yml. v4.1.0 defaults to cosign v3.0.3, which satisfies >= 2.6.0.releaser.ymlthat removes existing release assets before GoReleaser runs, so re-runs succeed after partial failures (e.g., after fixing WINGET_GITHUB_TOKEN).Files changed:
.github/workflows/releaser.yml— Add asset removal step..github/workflows/helm-publish.yml— Upgrade cosign-installer from v3.10.1 to v4.1.0..github/workflows/image-build-and-publish.yml— Upgrade cosign-installer from v3.10.1 to v4.1.0 in proxyrunner job..claude/skills/toolhive-release/references/WORKFLOW-REFERENCE.md— Add re-run troubleshooting note.Fixes #
Type of change
Test plan
task lint-fix)Changes
.github/workflows/releaser.yml.github/workflows/helm-publish.yml.github/workflows/image-build-and-publish.yml.claude/skills/toolhive-release/references/WORKFLOW-REFERENCE.mdDoes this introduce a user-facing change?
No.
Special notes for reviewers
The asset removal step only deletes assets when they exist (e.g., on re-runs). On first run it is effectively a no-op.
continue-on-erroris not used so the step fails ifghcommands are misconfigured.