Add printer columns to all CRDs#4489
Merged
Merged
Conversation
`kubectl get` output for config CRDs (MCPOIDCConfig, MCPTelemetryConfig, MCPExternalAuthConfig, MCPToolConfig) was minimal — showing only type/name and age. Operators had to use `-o yaml` to check readiness or which servers reference a config. This adds Ready and References columns to all config CRDs, renames MCPOIDCConfig's column to "Source" for clarity, and fixes the MCPGroup `printerColumn` typo that prevented its columns from rendering. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4489 +/- ##
==========================================
- Coverage 69.38% 69.33% -0.05%
==========================================
Files 501 501
Lines 51345 51345
==========================================
- Hits 35625 35600 -25
- Misses 12975 13000 +25
Partials 2745 2745 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blkt
approved these changes
Apr 2, 2026
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kubectl getoutput for config CRDs was minimal (just name + age), forcing operators to use-o yamlto check readiness or discover which MCPServers reference a config. This adds informative printer columns to all config CRDs and fixes inconsistencies found during audit.printerColumnmarker typo that silently prevented column rendering.Closes #4252
Type of change
Test plan
task test)task lint-fix)task operator-manifests) — verified generated YAML matches markersChanges
mcpoidcconfig_types.gomcptelemetryconfig_types.gomcpexternalauthconfig_types.gomcpgroup_types.goprinterColumntypo →printcolumn, reorder columnstoolconfig_types.godeploy/charts/operator-crds/**Does this introduce a user-facing change?
Yes.
kubectl getoutput is now significantly more informative for all CRDs:MCPOIDCConfig — before:
MCPOIDCConfig — after:
MCPTelemetryConfig — before:
MCPTelemetryConfig — after:
MCPExternalAuthConfig — before:
MCPExternalAuthConfig — after:
MCPToolConfig — before:
MCPToolConfig — after:
MCPGroup — before (columns silently missing due to typo):
MCPGroup — after (all columns now render):
Special notes for reviewers
+kubebuilder:printerColumnmarkers (capital C) which is not a recognized kubebuilder marker — only+kubebuilder:printcolumnworks. This means the Servers, Phase, and Age columns were silently dropped from the generated CRD. Only the Ready column (which used the correct spelling) was rendering."Valid"condition type (not"Ready") for their status, so the Ready column maps to.status.conditions[?(@.type=='Valid')].status.type=integerwith JSONPaths that resolve to arrays/maps, not integers — they produced empty output. Replaced with a Ready column.Generated with Claude Code