Replace ReferencingServers with ReferencingWorkloads on MCPExternalAuthConfig#4507
Merged
ChrisJBurns merged 1 commit intomainfrom Apr 3, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4507 +/- ##
==========================================
+ Coverage 69.04% 69.07% +0.02%
==========================================
Files 502 502
Lines 51909 51950 +41
==========================================
+ Hits 35843 35886 +43
+ Misses 13279 13277 -2
Partials 2787 2787 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
754895e to
ab435b3
Compare
…PExternalAuthConfig RFC-0023 specifies a structured referencingWorkloads list with kind and name fields on shared configuration CRD status. This migrates MCPExternalAuthConfig from plain []string to []WorkloadReference, following the pattern already implemented for MCPOIDCConfig in #4492. The deletion handler now uses a DeletionBlocked condition with reason ReferencedByWorkloads and requeues instead of returning an error. The watch handler also enqueues configs with stale ReferencingWorkloads entries to handle ref-removal and server-deletion cases. Closes #4491 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ab435b3 to
d7d12b9
Compare
jerm-dro
approved these changes
Apr 2, 2026
3 tasks
MatteoManzoni
pushed a commit
to DocPlanner/toolhive
that referenced
this pull request
Apr 4, 2026
…thConfig (stacklok#4507) Replace ReferencingServers with structured ReferencingWorkloads on MCPExternalAuthConfig RFC-0023 specifies a structured referencingWorkloads list with kind and name fields on shared configuration CRD status. This migrates MCPExternalAuthConfig from plain []string to []WorkloadReference, following the pattern already implemented for MCPOIDCConfig in stacklok#4492. The deletion handler now uses a DeletionBlocked condition with reason ReferencedByWorkloads and requeues instead of returning an error. The watch handler also enqueues configs with stale ReferencingWorkloads entries to handle ref-removal and server-deletion cases. Closes stacklok#4491 Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates MCPExternalAuthConfig from
ReferencingServers []stringtoReferencingWorkloads []WorkloadReference, aligning it with the structured workload reference pattern established on MCPOIDCConfig in #4492. This enables the status field to distinguish between different workload kinds (MCPServer, VirtualMCPServer, MCPRemoteProxy) rather than assuming all referencing workloads are MCPServers.Partial fix for #4491
Type of change
Changes
mcpexternalauthconfig_types.goReferencingServers []stringwithReferencingWorkloads []WorkloadReference, update printer columnmcpexternalauthconfig_controller.gofindReferencingWorkloads(), update reconcile/deletion logic to use structured refs withDeletionBlockedconditionmcpexternalauthconfig_controller_test.goWorkloadReference{Kind, Name}structsmcpexternalauthconfig_controller_integration_test.goWorkloadReference{Kind, Name}structsTest plan
go test ./cmd/thv-operator/controllers/... -run MCPExternalAuthConfig)task genSpecial notes for reviewers
Follows the exact pattern from #4492 (MCPOIDCConfig migration). MCPToolConfig migration is in a separate PR. MCPTelemetryConfig will follow separately.
Generated with Claude Code