Skip to content

Add missing shortNames to MCPRemoteProxy, EmbeddingServer, and MCPRegistry CRDs#4594

Merged
ChrisJBurns merged 1 commit intomainfrom
chrisburns/4592-add-missing-shortnames
Apr 7, 2026
Merged

Add missing shortNames to MCPRemoteProxy, EmbeddingServer, and MCPRegistry CRDs#4594
ChrisJBurns merged 1 commit intomainfrom
chrisburns/4592-add-missing-shortnames

Conversation

@ChrisJBurns
Copy link
Copy Markdown
Collaborator

Summary

Three CRDs (MCPRemoteProxy, EmbeddingServer, MCPRegistry) were the only ones lacking shortName in their +kubebuilder:resource markers, while all other 8 CRDs had them. This adds shortNames for consistency, so users can use kubectl get rp, kubectl get emb, and kubectl get mcpreg instead of typing full resource names.

Closes #4592

Type of change

  • Enhancement (non-breaking change which adds functionality)

Changes

File Change
cmd/thv-operator/api/v1alpha1/mcpremoteproxy_types.go Add shortName=rp;mcprp to kubebuilder resource marker
cmd/thv-operator/api/v1alpha1/embeddingserver_types.go Add shortName=emb;embedding to kubebuilder resource marker
cmd/thv-operator/api/v1alpha1/mcpregistry_types.go Add shortName=mcpreg;registry to kubebuilder resource marker
deploy/charts/operator-crds/files/crds/*.yaml Regenerated CRD manifests
deploy/charts/operator-crds/templates/*.yaml Regenerated Helm-wrapped CRD templates

Test plan

  • task lint-fix passes with 0 issues
  • task operator-test passes
  • Verified shortNames appear in regenerated CRD YAML files
  • Confirmed all 11 CRDs now have shortNames defined

Generated with Claude Code

…istry CRDs

These three CRDs were the only ones lacking shortName markers, creating
an inconsistent kubectl experience. Users can now use `kubectl get rp`,
`kubectl get emb`, and `kubectl get mcpreg` like all other ToolHive CRDs.

Closes #4592

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added the size/XS Extra small PR: < 100 lines changed label Apr 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.86%. Comparing base (44b9771) to head (5423ec3).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4594      +/-   ##
==========================================
- Coverage   68.90%   68.86%   -0.05%     
==========================================
  Files         505      505              
  Lines       52403    52403              
==========================================
- Hits        36108    36086      -22     
- Misses      13507    13527      +20     
- Partials     2788     2790       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisJBurns ChrisJBurns merged commit 1ddaaef into main Apr 7, 2026
40 checks passed
@ChrisJBurns ChrisJBurns deleted the chrisburns/4592-add-missing-shortnames branch April 7, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing shortNames to MCPRemoteProxy, EmbeddingServer, and MCPRegistry CRDs

2 participants