Add missing shortNames to MCPRemoteProxy, EmbeddingServer, and MCPRegistry CRDs#4594
Merged
ChrisJBurns merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
…istry CRDs These three CRDs were the only ones lacking shortName markers, creating an inconsistent kubectl experience. Users can now use `kubectl get rp`, `kubectl get emb`, and `kubectl get mcpreg` like all other ToolHive CRDs. Closes #4592 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4594 +/- ##
==========================================
- Coverage 68.90% 68.86% -0.05%
==========================================
Files 505 505
Lines 52403 52403
==========================================
- Hits 36108 36086 -22
- Misses 13507 13527 +20
- Partials 2788 2790 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JAORMX
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three CRDs (MCPRemoteProxy, EmbeddingServer, MCPRegistry) were the only ones lacking
shortNamein their+kubebuilder:resourcemarkers, while all other 8 CRDs had them. This adds shortNames for consistency, so users can usekubectl get rp,kubectl get emb, andkubectl get mcpreginstead of typing full resource names.Closes #4592
Type of change
Changes
cmd/thv-operator/api/v1alpha1/mcpremoteproxy_types.goshortName=rp;mcprpto kubebuilder resource markercmd/thv-operator/api/v1alpha1/embeddingserver_types.goshortName=emb;embeddingto kubebuilder resource markercmd/thv-operator/api/v1alpha1/mcpregistry_types.goshortName=mcpreg;registryto kubebuilder resource markerdeploy/charts/operator-crds/files/crds/*.yamldeploy/charts/operator-crds/templates/*.yamlTest plan
task lint-fixpasses with 0 issuestask operator-testpassesGenerated with Claude Code