Add RegistryServerName to RunConfig for registry entry tracking#4696
Open
Add RegistryServerName to RunConfig for registry entry tracking#4696
Conversation
Running workloads need to be mapped back to their registry entry by name so that downstream consumers (e.g. the registry export endpoint) can look up server metadata. Add a RegistryServerName field to RunConfig following the same pattern as RegistryAPIURL and RegistryURL: builder option, resolver helper, wiring through all three call sites, and regenerated OpenAPI docs. Part of stacklok/toolhive-rfcs#68 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4696 +/- ##
==========================================
+ Coverage 68.66% 68.71% +0.04%
==========================================
Files 509 509
Lines 52987 52999 +12
==========================================
+ Hits 36384 36418 +34
+ Misses 13782 13761 -21
+ Partials 2821 2820 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jhrozek
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RegistryServerNamefield toRunConfigfollowing the exact same pattern asRegistryAPIURLandRegistryURL: builder option, resolver helper, wiring through all three call sites (CLI, API, MCP handler), and regenerated OpenAPI docs.Type of change
Test plan
task test)task lint-fix)Changes
pkg/runner/config.goRegistryServerNamefield with JSON/YAML tagspkg/runner/config_builder.goWithRegistryServerNamebuilder option andResolveRegistryServerNamehelpercmd/thv/app/run_flags.gopkg/api/v1/workload_service.gopkg/mcp/server/run_server.gopkg/runner/config_builder_test.gopkg/mcp/server/handler_test.godocs/server/*Does this introduce a user-facing change?
No. The field is populated automatically during server creation and serialized in RunConfig state. No new CLI flags or API parameters are added.
Generated with Claude Code