Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4803 +/- ##
==========================================
+ Coverage 68.96% 69.02% +0.05%
==========================================
Files 517 517
Lines 54829 54829
==========================================
+ Hits 37815 37843 +28
+ Misses 14098 14068 -30
- Partials 2916 2918 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
LGTM — straightforward addition of Kiro as a skill-supporting client, following the same pattern as recent similar additions.
Extended reasoning...
Overview
The PR adds skill support to the existing Kiro client entry in pkg/client/config.go (3 lines: SupportsSkills, SkillsGlobalPath, SkillsProjectPath) and updates pkg/client/skills_test.go with corresponding fixture data, a TestSupportsSkills case, a count bump in TestListSkillSupportingClients, and two TestGetSkillPath cases.
Security risks
None. This is a path configuration change — it only adds a new directory path (.kiro/skills) where skill files are installed. No auth, crypto, or permission logic is touched.
Level of scrutiny
Low. The change is entirely mechanical and follows the identical pattern used when Goose, Gemini CLI, Amp, and others were added. The path convention (.kiro/skills/) is consistent with Kiro's documented conventions and requires no platform prefix (same approach as Cursor, ClaudeCode, etc.).
Other factors
The only bug found is a nit: the descriptive comment in TestListSkillSupportingClients lists clients in wrong alphabetical order ("Kiro, KimiCli" should be "KimiCli, Kiro" since kimi-cli < kiro lexicographically). The runtime assertion is unaffected and passes correctly. This is already captured as an inline comment. It does not warrant blocking the PR.
Summary
Enables Kiro as a skill-supporting client in ToolHive.
~/.kiro/skills/<name>(user scope) and<project>/.kiro/skills/<name>(project scope) — matching Kiro's native skill path conventionDocumentation reference: Kiro Agent Skills
Type of change
Test plan
task test)task lint-fix)Changes
pkg/client/config.goSupportsSkills,SkillsGlobalPath,SkillsProjectPathto the existingKiroconfig entrypkg/client/skills_test.goKiroto fixture,TestSupportsSkills,TestListSkillSupportingClients(12 → 13), andTestGetSkillPath(2 new cases)Does this introduce a user-facing change?
Yes —
thv skill install --clients kiro(or--clients all) now works. Skills land in~/.kiro/skills/so Kiro picks them up automatically.