Skip to content

Add Kiro as a skill-supporting client#4803

Merged
samuv merged 1 commit intomainfrom
kiro-skill-client
Apr 14, 2026
Merged

Add Kiro as a skill-supporting client#4803
samuv merged 1 commit intomainfrom
kiro-skill-client

Conversation

@samuv
Copy link
Copy Markdown
Contributor

@samuv samuv commented Apr 14, 2026

Summary

Enables Kiro as a skill-supporting client in ToolHive.

  • Skills install to ~/.kiro/skills/<name> (user scope) and <project>/.kiro/skills/<name> (project scope) — matching Kiro's native skill path convention
  • No platform prefix needed; paths are consistent across Linux, macOS, and Windows

Documentation reference: Kiro Agent Skills

Type of change

  • New feature

Test plan

  • Unit tests (task test)
  • Linting (task lint-fix)

Changes

File Change
pkg/client/config.go Add SupportsSkills, SkillsGlobalPath, SkillsProjectPath to the existing Kiro config entry
pkg/client/skills_test.go Add Kiro to fixture, TestSupportsSkills, TestListSkillSupportingClients (12 → 13), and TestGetSkillPath (2 new cases)

Does this introduce a user-facing change?

Yes — thv skill install --clients kiro (or --clients all) now works. Skills land in ~/.kiro/skills/ so Kiro picks them up automatically.

@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Apr 14, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.02%. Comparing base (943bafb) to head (caf2c02).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4803      +/-   ##
==========================================
+ Coverage   68.96%   69.02%   +0.05%     
==========================================
  Files         517      517              
  Lines       54829    54829              
==========================================
+ Hits        37815    37843      +28     
+ Misses      14098    14068      -30     
- Partials     2916     2918       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward addition of Kiro as a skill-supporting client, following the same pattern as recent similar additions.

Extended reasoning...

Overview

The PR adds skill support to the existing Kiro client entry in pkg/client/config.go (3 lines: SupportsSkills, SkillsGlobalPath, SkillsProjectPath) and updates pkg/client/skills_test.go with corresponding fixture data, a TestSupportsSkills case, a count bump in TestListSkillSupportingClients, and two TestGetSkillPath cases.

Security risks

None. This is a path configuration change — it only adds a new directory path (.kiro/skills) where skill files are installed. No auth, crypto, or permission logic is touched.

Level of scrutiny

Low. The change is entirely mechanical and follows the identical pattern used when Goose, Gemini CLI, Amp, and others were added. The path convention (.kiro/skills/) is consistent with Kiro's documented conventions and requires no platform prefix (same approach as Cursor, ClaudeCode, etc.).

Other factors

The only bug found is a nit: the descriptive comment in TestListSkillSupportingClients lists clients in wrong alphabetical order ("Kiro, KimiCli" should be "KimiCli, Kiro" since kimi-cli < kiro lexicographically). The runtime assertion is unaffected and passes correctly. This is already captured as an inline comment. It does not warrant blocking the PR.

@samuv samuv self-assigned this Apr 14, 2026
@samuv samuv merged commit 2dedbae into main Apr 14, 2026
46 of 47 checks passed
@samuv samuv deleted the kiro-skill-client branch April 14, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants