Remove stale OpenShift values overlay from Helm chart#4817
Conversation
The values-openshift.yaml was a copy of the default values with outdated image tags (v0.15.0) and different resource limits. It provided no OpenShift-specific configuration and was misleading as a reference. Remove it along with the README references that pointed to it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisJBurns
requested review from
JAORMX,
jerm-dro,
jhrozek and
yrobla
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM — straightforward removal of a stale, misleading values overlay with no functional impact.
Extended reasoning...
Overview
This PR removes deploy/charts/operator/values-openshift.yaml and the corresponding README references in README.md and README.md.gotmpl. The deleted file was a near-duplicate of the default values.yaml with outdated image tags (v0.15.0 vs current v0.20.0) and contained no actual OpenShift-specific configuration.
Security risks
None. This is a pure deletion of a stale values overlay and documentation cleanup. No templates, Go code, or runtime behavior is changed.
Level of scrutiny
Low. The changes are mechanical: delete an unused file, remove two identical README code blocks referencing it. The PR description confirms no Helm templates reference the deleted file, and the remaining OpenShift-related Go code (platform detection, security contexts) is unaffected.
Other factors
No bugs found by the automated system. The README and its template source are updated consistently. This is a clean, low-risk housekeeping change.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4817 +/- ##
==========================================
+ Coverage 68.94% 68.99% +0.05%
==========================================
Files 518 518
Lines 55017 55017
==========================================
+ Hits 37930 37960 +30
+ Misses 14159 14130 -29
+ Partials 2928 2927 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Summary
The
values-openshift.yamlwas a near-duplicate of the defaultvalues.yamlwith outdated image tags (v0.15.0 vs v0.20.0) and slightly different resource limits. It contained no OpenShift-specific configuration and was misleading as a named overlay. This PR removes it and cleans up the README references.Type of change
Test plan
values-openshift.yamlREADME.md.gotmpland generatedREADME.mdupdated consistentlyGenerated with Claude Code