Open
Conversation
Add upstream-compatible server browse endpoints:
- GET /registry/{name}/v0.1/servers (paginated, searchable)
- GET /registry/{name}/v0.1/servers/{serverName}/versions/latest
Servers are converted from ToolHive types to ServerJSON using
toolhive-core converters. Same pattern as the skills endpoint.
Combine skills and servers into a single RegistryV01Router with
shared helpers (provider accessor, pagination, JSON errors).
Refactor skills handlers to use shared helpers.
Ref: #4199
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4871 +/- ##
==========================================
+ Coverage 69.06% 69.09% +0.03%
==========================================
Files 531 533 +2
Lines 55172 55264 +92
==========================================
+ Hits 38104 38185 +81
- Misses 14140 14142 +2
- Partials 2928 2937 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Large PR Detected
This PR exceeds 1000 lines of changes and requires justification before it can be reviewed.
How to unblock this PR:
Add a section to your PR description with the following format:
## Large PR Justification
[Explain why this PR must be large, such as:]
- Generated code that cannot be split
- Large refactoring that must be atomic
- Multiple related changes that would break if separated
- Migration or data transformationAlternative:
Consider splitting this PR into smaller, focused changes (< 1000 lines each) for easier review and reduced risk.
See our Contributing Guidelines for more details.
This review will be automatically dismissed once you add the justification section.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
fd52881 to
d298cd4
Compare
The page overflow guard was computed against the default limit (50) before the actual limit from the query string was parsed. This meant (page-1)*limit could overflow when both a large page and custom limit were specified. Fix by parsing both page and limit first, then computing the cap. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
f1ab2bf to
94ae593
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/v1beta/registry/{name}/serversendpoint which returns ToolHive types.Fixes #4199
Type of change
Test plan
task test)task lint-fix)Changes
pkg/api/v1/registry_v01.gopkg/api/v1/registry_v01_servers.gopkg/api/v1/registry_v01_servers_test.gopkg/api/v1/registry_v01_skills.gopkg/api/v1/registry_v01_skills_test.gopkg/api/server.goRegistryV01Router()Does this introduce a user-facing change?
Yes — two new API endpoints:
GET /registry/{name}/v0.1/servers(paginated, searchable via?q=)GET /registry/{name}/v0.1/servers/{serverName}/versions/latestGenerated with Claude Code