Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4913 +/- ##
==========================================
- Coverage 69.40% 69.39% -0.01%
==========================================
Files 538 539 +1
Lines 55494 55677 +183
==========================================
+ Hits 38513 38636 +123
- Misses 14023 14069 +46
- Partials 2958 2972 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a “zero-config quick mode” for thv vmcp serve so users can run the vMCP server without a YAML config by specifying --group, generating a minimal in-memory config for the common local aggregation workflow.
Changes:
- Extend
ServeConfigwithGroupRefand updateServe()to load config from--configor generate quick-mode config from--group. - Add
generateQuickModeConfig()helper and unit tests for quick-mode config generation and the “neither flag provided” error path. - Update
thv vmcp serveCLI flags/docs: remove required--config, add--group, regenerate command docs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pkg/vmcp/cli/serve.go | Adds GroupRef quick-mode branching and helper to generate/validate an in-memory config. |
| pkg/vmcp/cli/serve_test.go | Adds tests for quick-mode config generation and for erroring when neither --config nor --group is provided. |
| cmd/thv/app/vmcp.go | Updates Cobra command flags: --config no longer required; adds --group and passes it to Serve(). |
| docs/cli/thv_vmcp_serve.md | Documents quick mode and updates the options list to include --group. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When --config is omitted, --group enables quick mode: a minimal in-memory
config is generated from the named ToolHive group so no config file is
needed for the common local-aggregation case.
- Add GroupRef field to ServeConfig; Serve() branches on ConfigPath vs
GroupRef vs neither (error)
- Add generateQuickModeConfig: anonymous auth, inline outgoing, prefix
aggregation, validated before use
- Remove MarkFlagRequired("config"); add --group flag to serve command
- Regenerate docs/cli/thv_vmcp_serve.md
Closes #4886
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
When --config is omitted, --group enables quick mode: a minimal in-memory config is generated from the named ToolHive group so no config file is needed for the common local-aggregation case.
Fixes #4886
Type of change
Test plan
task test)task test-e2e)task lint-fix)Changes
Does this introduce a user-facing change?
Implementation plan
Approved implementation plan
Special notes for reviewers