Use corev1.PullPolicy instead of string for EmbeddingServer ImagePullPolicy #5240
Merged
Conversation
Signed-off-by: Sanskarzz <sanskar.gur@gmail.com>
ChrisJBurns
previously approved these changes
May 10, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5240 +/- ##
=======================================
Coverage 67.97% 67.97%
=======================================
Files 612 612
Lines 62723 62723
=======================================
+ Hits 42633 42636 +3
+ Misses 16908 16899 -9
- Partials 3182 3188 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Sanskarzz <sanskar.gur@gmail.com>
ChrisJBurns
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
EmbeddingServerSpec.ImagePullPolicyto usecorev1.PullPolicyinstead of a plain string.This keeps the existing kubebuilder enum validation and JSON schema behavior unchanged, while giving Go code compile-time safety and consistency with upstream Kubernetes container image pull policy types.
Fixes #4616
Type of change
Test plan
task test)task test-e2e)task lint-fix)API Compatibility
v1beta1API, OR theapi-break-allowedlabel is applied and the migration guidance is described above.Changes
EmbeddingServerSpec.ImagePullPolicyfromstringtocorev1.PullPolicyGetImagePullPolicy()to returncorev1.PullPolicycorev1.PullAlways,corev1.PullNever, andcorev1.PullIfNotPresent