Skip to content

Bump testcontainers-go to v0.42.0 to drop docker/docker#5449

Merged
rdimitrov merged 1 commit into
mainfrom
bump-testcontainers-go-0.42.0
Jun 3, 2026
Merged

Bump testcontainers-go to v0.42.0 to drop docker/docker#5449
rdimitrov merged 1 commit into
mainfrom
bump-testcontainers-go-0.42.0

Conversation

@rdimitrov
Copy link
Copy Markdown
Member

@rdimitrov rdimitrov commented Jun 3, 2026

Summary

A vulnerability scan flagged github.com/docker/docker v28.5.2+incompatible. That module is deprecated as of Docker v29 (no newer Go-module version exists), and ToolHive already ships the new moby/moby/{client,api} modules — docker/docker only lingered as a test-only indirect dep of testcontainers-go.

Bumping testcontainers-go v0.40.0 → v0.42.0 (which itself migrated to moby/moby/{client,api}) removes docker/docker from the graph entirely. No source changes.

Type of change

  • Dependency update

Test plan

  • Unit tests (task test)
  • Manual testing: ran pkg/authserver/storage integration tests (-tags integration -race, the only testcontainers-go consumer) against real Redis — all pass. Confirmed docker/docker is gone from go.mod/go.sum.

Does this introduce a user-facing change?

No.

Generated with Claude Code

A vulnerability scan flagged github.com/docker/docker
v28.5.2+incompatible in the operator and proxy-runner images. That
module is deprecated as of Docker v29 (moby split it into
github.com/moby/moby/{client,api}), and the docker-v29.x tags cannot be
consumed via `go get`, so there is no newer module version to update
to. ToolHive's production code already imports moby/moby/{client,api};
docker/docker lingered only as a test-only indirect dependency of
testcontainers-go.

testcontainers-go v0.42.0 migrated off docker/docker onto
moby/moby/{client,api}. Bumping from v0.40.0 and running `go mod tidy`
removes docker/docker (and the now-orphaned morikuni/aec) from the
module graph entirely, clearing the finding at its source. No source
changes are required; the authserver/storage integration tests pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@rdimitrov rdimitrov requested a review from JAORMX as a code owner June 3, 2026 19:21
@github-actions github-actions Bot added the size/XS Extra small PR: < 100 lines changed label Jun 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.85%. Comparing base (a785995) to head (b64bc14).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5449      +/-   ##
==========================================
- Coverage   68.85%   68.85%   -0.01%     
==========================================
  Files         634      634              
  Lines       64437    64437              
==========================================
- Hits        44371    44368       -3     
- Misses      16789    16790       +1     
- Partials     3277     3279       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Jun 3, 2026
@rdimitrov rdimitrov merged commit 340f4fd into main Jun 3, 2026
43 checks passed
@rdimitrov rdimitrov deleted the bump-testcontainers-go-0.42.0 branch June 3, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants