Replace opaque Step A/B labels in XAA CRD comments#5703
Open
jhrozek wants to merge 1 commit into
Open
Conversation
"Step A" and "Step B" in the XAASpec struct comments and the generated CRD YAML descriptions don't tell the reader what each step does or which endpoint it targets. Rename throughout to "IdP exchange" (RFC 8693 token exchange at the user's IdP, produces the ID-JAG) and "target grant" (RFC 7523 JWT bearer grant at the target AS, produces the backend access token). Regenerate the CRD YAML with task operator-manifests. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
jhrozek
requested review from
ChrisJBurns,
JAORMX,
blkt,
jerm-dro,
rdimitrov,
reyortiz3 and
tgrunnagle
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5703 +/- ##
==========================================
+ Coverage 70.61% 70.65% +0.03%
==========================================
Files 667 667
Lines 67607 67607
==========================================
+ Hits 47743 47765 +22
+ Misses 16410 16373 -37
- Partials 3454 3469 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
XAASpecstruct comments and the generated CRD YAML descriptions used"Step A" and "Step B" to refer to the two phases of the ID-JAG protocol.
These labels are opaque — they tell the reader nothing about what each step
does or which endpoint it targets, and they're easy to confuse with each
other.
Replace them throughout with action-oriented names:
The rename covers the
ExternalAuthTypeXAAconst comment, theXAASpectype comment, and every field description that referenced the old labels
(
IDPTokenURL,IDPClientID,TargetTokenURL,TargetClientID,TargetResource,Scopes,SubjectTokenType). CRD YAML regenerated withtask operator-manifests.Type of change
Test plan
task operator-manifestsran cleanly; generated YAML contains zero occurrences of "Step A" or "Step B"grep -c "Step A\|Step B"on generated YAML: output0Generated with Claude Code