Skip to content

test(parser): bucket pam session closures#43

Merged
stacknil merged 1 commit into
mainfrom
stacknil/loglens-pam-session-closed-telemetry
May 28, 2026
Merged

test(parser): bucket pam session closures#43
stacknil merged 1 commit into
mainfrom
stacknil/loglens-pam-session-closed-telemetry

Conversation

@stacknil
Copy link
Copy Markdown
Owner

Summary

  • add a stable pam_unix_session_closed unknown-pattern bucket for unsupported PAM session-close lines
  • keep session-close evidence out of parsed events and detector signals
  • update parser and detector boundary tests for syslog and journalctl fixtures

Validation

  • & 'C:\Program Files (x86)\Microsoft Visual Studio\18\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe' --build build --config Debug --target test_parser
  • & 'C:\Program Files (x86)\Microsoft Visual Studio\18\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\ctest.exe' --test-dir build -C Debug -R parser --output-on-failure
  • & 'C:\Program Files (x86)\Microsoft Visual Studio\18\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe' --build build --config Debug --target test_detector
  • & 'C:\Program Files (x86)\Microsoft Visual Studio\18\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\ctest.exe' --test-dir build -C Debug -R detector --output-on-failure
  • & 'C:\Program Files (x86)\Microsoft Visual Studio\18\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\ctest.exe' --test-dir build -C Debug --output-on-failure
  • & 'C:\Program Files (x86)\Microsoft Visual Studio\18\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe' --build build --config Debug

@stacknil stacknil merged commit 736e66b into main May 28, 2026
7 checks passed
@stacknil stacknil deleted the stacknil/loglens-pam-session-closed-telemetry branch May 28, 2026 03:40
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 548c4eec70

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/parser.cpp

if (event.program.starts_with("pam_unix(")) {
if (message.starts_with("session closed for user ")) {
return "pam_unix_session_closed";
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Document the new parser telemetry bucket

This introduces the user-visible pam_unix_session_closed warning/top_unknown_patterns bucket, but the commit does not update README or docs. AGENTS.md requires README/docs updates for user-visible changes, and the parser contract/README still only describe unsupported-line telemetry generically, so users relying on stable bucket names do not have this new output documented.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant