[codex] reduce noisy repeated alerts with cooldown#9
Merged
Conversation
Owner
Author
|
@codex review
|
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2.
This PR adds a small, repo-local alert cooldown to reduce repeated noisy alerts caused by overlapping windows while keeping the current rule-based design intact.
Before this change, the same rule could trigger on many adjacent overlapping windows in the sample dataset, which made the default output noisy and harder to explain. The main cause was that
apply_rulesemitted every matching window independently, even when those windows were only 10 seconds apart and clearly part of the same burst.The fix is intentionally simple:
cooldown_secondssetting underrulesinconfigs/default.yamlrule_nameplusalert_timeWith the default sample config,
cooldown_secondsis set to60, which matches the current window size. That reduces the bundled sample output from 53 alerts to 12 alerts without changing the underlying window features or moving away from the existing MVP rule model.Validation
pytest tests/test_rules.pypytest tests/test_pipeline_e2e.py -qpytestExact cooldown behavior
For the default config, once an alert is emitted for a given
rule_name, additional alerts with that samerule_nameare suppressed until at least 60 seconds have elapsed since the last emitted alert for that rule. The comparison uses each alert'salert_time. An alert that lands exactly 60 seconds after the last emitted alert for the same rule is allowed through. Different rule names do not suppress each other.