Fix tvOS CI #224
Merged
Fix tvOS CI #224
+100
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like about six hours ago, a commit was pushed to https://github.com/thebrowsercompany/swift-windowsfoundation that means it can no longer be pulled in by xcodebuild. (Not sure why it's succeeding on Linux; you'd think xcodebuild and SPM would resolve dependencies the same way.) Sometime thereafter, the repository was archived, so we shouldn't expect an update to come and fix it. I can't point it at an older commit because one of our dependencies also points at |
stackotter
requested changes
Oct 18, 2025
stackotter
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #223
Turns out the
set -ecall in the script was almost immediately followed byset +e, so I had to move it further down to make the tests fail correctly. Then I updated the code so now it actually builds on tvOS.