-
-
Notifications
You must be signed in to change notification settings - Fork 59
Date picker #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Date picker #244
Conversation
|
The thought just occurred to me to observe NSSystemTimeZoneDidChange to properly redraw views that use |
|
There’s a backend method called setEnvironmentChangeHandler or something like that. That’s where we currently observe system theme changes and would be where timezone observation should live as well. |
|
Right, I'll go see if I can get that to work in UIKitBackend and AppKitBackend first, and then maybe the other backends. I don't think it'll necessarily work on Linux though |
|
Marking this as draft because UIDatePicker (at least on iOS 17) completely misbehaves if the user changes the time zone in settings |
Fixes #233
Each backend has its own shortcomings:
hourMinuteAndSecond, and doesn't respect font colorwheelpicker stylehourMinuteAndSecond, doesn't respect font color, and doesn't respectenvironment.timeZone(instead always using the current time zone)graphicalpicker style, doesn't respectenvironment.timeZone(instead always using UTC), and only supports picking the date, not the time