-
-
Notifications
You must be signed in to change notification settings - Fork 18
Fix build errors and warnings #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
maximkrouk
commented
Aug 24, 2023
- Updated and locked (to avoid unexpected build errors) swift-syntax version
- Fixed deprecation warnings
- Fixed compilation errors
- Fixed tests
- Couldn't fix AddAsync/AddCompletionHandler macros, they are called multiple times and produce diagnostic errors, but since it's a showcase I guess it shouldn't be a blocker for fixing compilation errors
- Updated and locked swift-syntax version - Fixed deprecation warnings - Fixed compilation errors - Fixed tests ----- Couldn't fix AddAsync/AddCompletionHandler macros, they are called multiple times and produce diagnostic errors
|
Hey Maxim, thanks for the PR! I'll have a look at your changes and then merge if all good, but I've got a deadline today followed by an all-weekend event, so I likely won't get around to fixing the example macros (which I'd like to do before releasing v0.2.0). For some reason I thought I'd already locked the swift-syntax version which would've avoided those build errors and warnings from appearing 😅 thanks for picking up on that and updating the dependency while you were at it, that'll also save me some time when updating to the stable release of swift-syntax whenever that happens. |
stackotter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍 there are a few things I'll change, but to get this merged today I'll do that when I update the broken macros.
|
I'm actually quite pleasantly surprised about the changes that they've made to swift-syntax since I last used it. The newer API changes make it feel more swifty and consistent. |
|
Yeah, the new API feels fancier 😅 Btw I was thinking about updates, it feels kinda important to keep up with the latest |
Hmm yeah that could be a good idea. I finally got around to fixing up the tests so I've added the |
|
Random fun fact: Hopefully xcode reinstall will help 😅 |
|
Lol rip, that's always so annoying when that happens |
|
Well, after hours of searching for workarounds I managed to fix the issue, I simply forgot to declare a compiler plugin type 😅, but the error was not helpful at all 💀 |
|
Haha that’s still weird that it didn’t happen in CI 🤔 macro compilation errors could definitely do with some improvement lol |