Skip to content

Fix cargo binary install conflicts in CI#248

Open
ChristianPavilonis wants to merge 1 commit intomainfrom
fix/ci-issues
Open

Fix cargo binary install conflicts in CI#248
ChristianPavilonis wants to merge 1 commit intomainfrom
fix/ci-issues

Conversation

@ChristianPavilonis
Copy link
Copy Markdown
Contributor

@ChristianPavilonis ChristianPavilonis commented Apr 22, 2026

Summary

  • fix CI failures caused by caching ~/.cargo/bin/ and then reinstalling Cargo binaries
  • remove the cached Cargo bin directory from workflow caches to avoid stale installed executables
  • force the Viceroy install step so repeat installs do not fail when the binary already exists

Changes

Crate / File Change
.github/workflows/test.yml Removed ~/.cargo/bin/ from the cache path list and changed cargo install viceroy --locked to cargo install viceroy --locked --force
.github/workflows/format.yml Removed ~/.cargo/bin/ from the cache path list

Closes

Closes #249

Test plan

  • cargo test --workspace --all-targets
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo check --workspace --all-targets --features "fastly cloudflare"
  • WASM builds: wasm32-wasip1 (Fastly) / wasm32-unknown-unknown (Cloudflare)
  • Manual testing via edgezero-cli dev
  • Other: reviewed the workflow diff locally; this PR only changes GitHub Actions YAML

Checklist

  • Changes follow CLAUDE.md conventions
  • No Tokio deps added to core or adapter crates
  • Route params use {id} syntax (not :id)
  • Types imported from edgezero_core (not http crate)
  • New code has tests
  • No secrets or credentials committed

Copy link
Copy Markdown
Contributor

@aram356 aram356 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix duplicate Cargo binary install failures in CI

2 participants