Fix SVG Creative Display & Code Quality Improvements#13
Conversation
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Configure SSH for git dependencies |
There was a problem hiding this comment.
I was considering this for my docker build but thought we were going to make edge zero public. Are we holding off on that for any reason?
There was a problem hiding this comment.
I am not against it. We can make Github repo open for now. Let's agree on this together.
|
One thing we should consider doing is adding some info to the creatives. |
This is a good idea. Make it a ticket? We can also add some more meta to HTML comments if it too much to display in a banner Done: #14 |
Resolves
Summary
CAPFONTcalculation to cap at 16px instead of scaling too largeoverflow:hiddenfrom SVG that was clipping contentOther Changes
Code Quality
HashMapwith compile-timephf_map!for SIZE_MAP (zero-cost initialization)build_openrtb_responsefunctions into single implementation.map()with idiomaticlet-elsepatternunwrap()afteris_none()check anti-patternescape_htmlfunctionMAX_AREA_CPM→MAX_AREA_BONUSfor clarityNew Features
/_/sizesendpoint returning JSON with all standard ad sizesdecode_aps_price()function for base64 price decodingstandard_sizes()iterator for programmatic size accessTesting
playwrightjob to GitHub Actions CIDocumentation & Housekeeping
/_/sizesAPI docs, and test instructionsnodejs 24.12.0to.tool-versions.gitignoreTest plan
cargo testpasses